On Thu, 21 Mar 2024 16:17:33 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Adding library and build clauses > > test/jdk/java/awt/FileDialog/FileDialogForPackages.java line 59: > >> 57: frame.add(textScrollPane, BorderLayout.CENTER); >> 58: >> 59: fd = new FileDialog(new Frame(), "Open"); > > is there any need to mix Swing and AWT components in the test? I guess you > can use the JFrame already created Actually you don't need the textOutput, with recent changes you can add `.logArea()` to the PassFailJFrame builder https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L1200 and just use `PassFailJFrame.log()` wherever you need it. So this method can be changed to return the a `JButton`, and use it with `splitUIBottom`/`splitUIRight` instead of testUI ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18360#discussion_r1534625825
