On Thu, 21 Mar 2024 17:56:14 GMT, Phil Race <p...@openjdk.org> wrote:
>> test/jdk/java/awt/datatransfer/HTMLDataFlavors/ManualHTMLDataFlavorTest.java
>> line 110:
>>
>>> 108: } catch (UnsupportedFlavorException | IOException e) {
>>> 109: e.printStackTrace();
>>> 110: }
>>
>> Should exception make the test fail?
>
> The author of the test didn't think so, this doesn't seem related to
> converting to a main program
> so I don't want to touch it.
I feel as if it were a common practice in the olden days… It's commonly seen in
manual tests.
It's worth questioning whether the test should fail if an exception occurs…
Likely it should unless the exception *is* expected.
Yeah, this adds up… However, coming back to it later will require even more
time if it ever happens again especially if no issue to track it is submitted.
Submitting an issue also requires time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18334#discussion_r1535500404
