On Fri, 22 Mar 2024 17:28:10 GMT, Damon Nguyen <[email protected]> wrote:
>> test/jdk/javax/swing/JColorChooser/8065098/JColorChooserDnDTest.java line 47: >> >>> 45: frame.setContentPane(panel); >>> 46: frame.pack(); >>> 47: frame.setVisible(true); >> >> frame dispose is not required? > > This is a manual test. If I add dispose, it would close the application on > startup. The `JFrame.EXIT_ON_CLOSE` call should handle this I believe. > There's `DISPOSE_ON_CLOSE`, but I don't think this is right here. I agree, `JFrame.EXIT_ON_CLOSE` should be sufficient in this case. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18436#discussion_r1535968998
