On Sat, 23 Mar 2024 23:38:51 GMT, Phil Race <p...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix spelling
>
> test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 49:
>
>> 47: with two buttons: "Page Dialog" and "Print Dialog".
>> 48: 1. Make the "Test Frame" active by clicking on title.
>> 49: 2. Press "Page Dialog" button and a page dailog should
>> popup.
>
> dailog -> dialog
Fixed. Thanks.
> test/jdk/java/awt/print/PrinterJob/PrinterDialogsModalityTest.java line 68:
>
>> 66: .title("PrinterDialogsModalityTest Test Instructions")
>> 67: .instructions(INSTRUCTIONS)
>> 68: .rows((int) INSTRUCTIONS.lines().count() + 2)
>
> Oh, that's a nice idea. I'd been tweaking by hand.
I agree it's a nice idea, but I took this idea from other PR's I've reviewed.
Not sure who started this first, but very handy.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538152306
PR Review Comment: https://git.openjdk.org/jdk/pull/18461#discussion_r1538153170
