On Mon, 25 Mar 2024 07:42:47 GMT, Tejesh R <[email protected]> wrote:
> Since this is a manual test, should we wait for user to input some action
> like start print or something like that ? Because as soon as the test starts/
> printer job is initiated. Instructions are there, but I felt without user
> starting the test, the test is running as soon as it is executed, is it fine?
I figured it was fine, but there's no harm in making a dedicated button for it.
I went ahead and added the button to the `PassFailJFrame` as suggested. Thanks
for the suggestion. @TejeshR13 could you re-review this when you get the chance?
> test/jdk/java/awt/print/PageFormat/SetOrient.java line 46:
>
>> 44:
>> 45: public class SetOrient {
>> 46: static PrinterJob pjob;
>
> Can be moved inside `init()` and even you change the method name since applet
> is removed.
Renamed method to `createAndShowGUI`. Also moved `pjob` var into method.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18462#issuecomment-2018805769
PR Review Comment: https://git.openjdk.org/jdk/pull/18462#discussion_r1538162365
