On Tue, 26 Mar 2024 15:03:40 GMT, rjolly <[email protected]> wrote: >> ChangedCharSetException is used to amend the charset during read according >> to html directives. Currently it causes immediate exit of the method which >> in turn causes failure to load html documents with charset directives (even >> if the latter must not change after all). This PR restores the catch >> operation as it was before the use of try with resources. > > rjolly has updated the pull request incrementally with one additional commit > since the last revision: > > 8328953 : JEditorPane.read throws ChangedCharSetException > > The fix is to add a nested `try`-block inside `try-with-resource`; all the > exceptions are handled in the nested `try`; the outer `try`-with-resouces > only closes the input stream.
test/jdk/javax/swing/JEditorPane/EditorPaneCharset.java line 69: > 67: Element body = root.getElement(1); > 68: Element p = body.getElement(0); > 69: String pText = document.getText(p.getStartOffset(), Unhandled exception here (`BadLocationException`), for `getText()`. Also extra braces at end. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17567#discussion_r1540415503
