On Fri, 29 Mar 2024 09:49:54 GMT, Tejesh R <[email protected]> wrote: >> Convert and open source these manual applet test to main based: >> java/awt/Frame/MegaIconTest/MegaIconTest.html >> java/awt/Frame/FrameMaximizedTest/FrameMaximizedTest.html >> java/awt/Frame/FrameMinimizeTest/FrameMinimizeTest.html >> java/awt/Frame/SizeMinimizedTest/SizeMinimizedTest.html >> >> Automated the test SizeMinimizedTest.java. Since the test is failing Linux >> arch (Maybe related to the bug - >> [JDK-8305915](https://bugs.openjdk.org/browse/JDK-8305915)), the test is >> problem listed for Linux arch until the issue is fixed/further investigation >> is done. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Reveiw updates and SizeMinimizedTest converted to auto test
Changes requested by honkar (Reviewer). test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 58: > 56: String INSTRUCTIONS = """ > 57: Each of the buttons in the main window represents a test > 58: of certain icon functionality - transparency/opacity, > scaling etc. The instructions would be more clear if stated as - **background transparency/opacity of the icon**. test/jdk/java/awt/Frame/MegaIconTest/MegaIconTest.java line 194: > 192: setLayout(new BorderLayout()); > 193: > 194: //Add the icon graphic and instructions to the Frame The background transparency of different gifs can be checked by setting the background of the Frame to a different color. For instance `setBackground(Color.YELLOW)` here and in the original test. Adding a different background color instead of white makes it easier for the tester to compare the different types of icon. ------------- PR Review: https://git.openjdk.org/jdk/pull/18448#pullrequestreview-1969318862 PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544765763 PR Review Comment: https://git.openjdk.org/jdk/pull/18448#discussion_r1544761418
