On Sat, 30 Mar 2024 21:17:23 GMT, Phil Race <p...@openjdk.org> wrote:
>> Man Cao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright year > > src/java.desktop/unix/native/libsplashscreen/splashscreen_sys.c line 393: > >> 391: pthread_mutex_init(&splash->lock, NULL); >> 392: >> 393: // We should not ignore any errors. > > The 2nd commented out call looks like it might have been doing something > better than the default handler, > but not by so much as to matter. > The comment seems a bit inappropriate now and I'm puzzled why we need to > reinstall the default handler > (ie the call taking NULL), since we haven't installed a non-default handler > anyway. > I'd be inclined to remove the comment and the call. Thanks. Makes sense, removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18556#discussion_r1546676556
