On Tue, 2 Apr 2024 17:06:47 GMT, Alexey Ivanov <[email protected]> wrote:
>> It is better to re-throw it as RuntimeException. Updated. > >> It is better to re-throw it as RuntimeException. Updated. > > Not really… > > If saving the image fails, we want to preserve *the original error message* > which wasn't even thrown by this time. So printing stack trace in this > particular is quite safe, the exception could be ignored completely. Good point. Updated to print stacktrace in case IOException occurs, so as to prevent masking the original more priority test exception. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18523#discussion_r1548326772
