On Thu, 18 Apr 2024 04:47:15 GMT, Abhishek Kumar <[email protected]> wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to support the fix and there is no regression
>> caused by the fix.
>>
>> Proposed fix is tested in Ubuntu 22.04 and Oracle linux.
>>
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Number of tab increased
test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 83:
> 81: - Select the 'content opaque' and check that content area
> is opaque
> 82: (it must be gray).
> 83: Check this behaviour for other LAFs and tab layout.
@kumarabhi006 Click to check box 'content opaque' might seem unclear, whether
the checkbox needs to be checked or unchecked. It is better to replace it with
phrases - "checked/unchecked" or "select/unselect" as below.
Same applies to Case 1 and Case 3.
Test Case 2 - Test Content pane opacity:
To test Content pane opacity, make sure "Opaque checkbox" is UNCHECKED.
Verify the following with 'content opaque' option:
- when checked: the content area should be opaque (it must be gray).
- when unchecked: the content area should be transparent (it must be green).
Check this behavior for other LAFs and tab layout.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1571572910
