On Mon, 22 Apr 2024 21:41:12 GMT, Damon Nguyen <[email protected]> wrote:
>> Instructions set has been updated as per OS specific. JTable keyboard >> navigation is tested in each OS and according it's current implementation >> the instructions has been updated (Few has been removed and few has been >> updated). >> PassFailJFrame.builder is used. > > test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 190: > >> 188: PassFailJFrame.builder() >> 189: .instructions(INSTRUCTIONS) >> 190: .rows(11) > > Suggestion: > > .rows((int) INSTRUCTIONS.lines().count() + 2) > > > This is what we used for our tests. I default to using this now myself. This doesn't work here since the Instruction rows are quite more. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18855#discussion_r1575777024
