On Mon, 29 Apr 2024 10:44:37 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
> Some tests try to get the focus of a window by clicking on its title bar. > > On XWayland, however, emulating mouse clicks with XTEST currently only > affects the XWayland server, not the window decorations, so trying to click > on the window title will have no effect. > > So the solution is to click inside the window or call `toFront()` to get the > window focused. > > Some tests have issues with AWT/Swing calls not being on EDT, it is not the > goal of this change to fix them as they require way too many code changes, > and make this PR hard to review. Tested on Ubuntu 23.04. Changes look good. test/jdk/java/awt/Focus/ModalDialogInFocusEventTest.java line 29: > 27: @summary Showing modal dialog during dispatching SequencedEvent > 28: @key headful > 29: @run main ModalDialogInFocusEventTest Minor: Better to have the `@key` tag after `@test`. ------------- Marked as reviewed by honkar (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18995#pullrequestreview-2029591268 PR Review Comment: https://git.openjdk.org/jdk/pull/18995#discussion_r1583728864
