On Fri, 3 May 2024 04:38:07 GMT, Tejesh R <[email protected]> wrote: >> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unselected tab background property added > > test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 56: > >> 54: private static JTabbedPane tabPane; >> 55: private static final String INSTRUCTIONS = """ >> 56: The background color of panel (which contains the tabbed >> pane is green). > > Can you reframe this sentence because it doesn't mention about the color, > except you have mentioned in braces.
Updated. > test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 125: > >> 123: tabPane.setTabLayoutPolicy(JTabbedPane.SCROLL_TAB_LAYOUT); >> 124: tabPane.setTabPlacement(JTabbedPane.TOP); >> 125: PassFailJFrame.addTestWindow(frame); > > Is it required to add `frame` explicitly to PassFailJFrame here? Looks redundant to me, removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588717738 PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1588717479
