On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla <d...@openjdk.org> wrote:
> If you're currently reviewing this PR, thank you! > Most fixes here are according to the reports by the since checker tool in > #18934 and are pretty simple. > > To make reviewing easier > - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a > long time so the default constructor (without parameters) didn't exist until > JDK 16 > > For the `package-info` files, it is pretty hard to find source code of JDK > 1-5 so I used the `grep` command to find the oldest instance of an `@since` > in those packages. > > I found instances of `@since 1.1` in the other packages but > `javax/swing/plaf/synth/package-info.java` might be worth checking as most > classes there had no `@since`. src/java.desktop/share/classes/javax/swing/package-info.java line 153: > 151: * @serial exclude > 152: * > 153: * @since 1.1 This isn't right. Where did you get this from ? Swing only became part of the JDK in JDK 1.2 It was an unbundled library before then. If you find any @since 1.1 tags in the Swing API they are a mistake. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19192#discussion_r1600695814
