On Tue, 21 May 2024 23:08:17 GMT, Phil Race <[email protected]> wrote:
>> Enhance Font2DTest as follows
>>
>> - Add main menu Radio Button options so that you select the font to use as
>> either
>> - (1) Font Family + Style (as now)
>> - (2) Font Family + Menu of all members of the Family, replacing the Style
>> - (3) List of all fontnames - which can still be adjusted by Style if you
>> want.
>> The default is (1) so nothing looks different except that I updated the UI
>> to use Nimbus instead of Metal.
>>
>> There's new code to gather these ways of referencing the fonts.
>> Also changes were needed for the "Save/Load" options to include the new UI
>> state and font settings.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8332416
src/demo/share/jfc/Font2DTest/Font2DTest.java line 1440:
> 1438: f.addWindowListener( new WindowAdapter() {
> 1439: public void windowOpening( WindowEvent e ) {
> f2dt.repaint(); }
> 1440: public void windowClosing( WindowEvent e ) {
> System.exit(0); }
@prrace Minor Spacing issue. I see this pattern in the original code as well,
could be a quick find+replace all fix for opening and closing brace. But then
again it would also create a lot of git diff footprint along with the fix.
Suggestion:
f.addWindowListener( new WindowAdapter() {
public void windowOpening(WindowEvent e) { f2dt.repaint(); }
public void windowClosing(WindowEvent e) { System.exit(0); }
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19273#discussion_r1612165764
