On Thu, 23 May 2024 12:45:31 GMT, Artem Semenov <aseme...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replaced NULL with nil in OutlineAccessibility - functionally it has no >> effect but it is more uiform and according to the ObjectibeC convention >> where objects are referred as nil and references to the primitives as NULL. > > src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/OutlineAccessibility.m > line 141: > >> 139: [super postSelectedCellsChanged]; >> 140: } >> 141: > > It seems to me that it is also worth defining a destructor that will destroy > the cache before destroying the instance. The problem is that on Java side we are notified when the accessibility is being enabled but we have no notification of when it is no longer used so we do not deliberately release native peers and in my testing even when i add dealloc function to the class it is never being called. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19255#discussion_r1612846856
