On Tue, 28 May 2024 04:53:08 GMT, Abhishek Kumar <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Additional null check
>
> src/java.desktop/share/classes/javax/swing/ToolTipManager.java line 271:
>
>> 269: toFind = mouseEvent.getLocationOnScreen();
>> 270: } else {
>> 271: toFind = screenLocation;
>
> Why `toFind` is set to `screenLocation` ?
If mouse movement is not there, then it is imperative to use the original
screenlocation to find GraphicsConfiuration but as told this codepath was not
used so probably a no-op and should not be an issue..
> src/java.desktop/share/classes/javax/swing/ToolTipManager.java line 310:
>
>> 308: }
>> 309: } else {
>> 310: if (mouseEvent != null) {
>
> this may not be in the scope of changes but is it worth spending some time
> for code formatting ? Looks very messy.
may be as a cleanup later on, the whole file formatting is off at many places..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19379#discussion_r1616702383
PR Review Comment: https://git.openjdk.org/jdk/pull/19379#discussion_r1616703095
