On Fri, 31 May 2024 14:49:45 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Non-client aread edge area modified, test format
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m line 1031:
>
>> 1029: (p.x >= (frame.origin.x + contentRect.size.width - 3))
>> ||
>> 1030: (fabs(frame.origin.x - p.x) < 3) ||
>> 1031: (fabs(frame.origin.y - p.y) < 3)) {
>
> Does `fabs` use float? It makes code more compact but it may be imprecise and
> less performant than integer arithmetics.
Yes..https://man7.org/linux/man-pages/man3/fabs.3.html and [CGFLoat
](https://developer.apple.com/documentation/corefoundation/cgfloat?language=objc)
can be double/float and fabs can accomodate both, in this case it uses
double...We have tested on 3 different systems without any issue so would keep
it for now until we find any adverse effect..
> test/jdk/javax/swing/JMenu/TestUngrab.java line 101:
>
>> 99: robot.delay(1000);
>> 100: System.out.println("isPopupMenuVisible " +
>> menu.isPopupMenuVisible());
>> 101: if (menu.isPopupMenuVisible()) {
>
> `menu.isPopupMenuVisible()` should also be accessed on EDT.
Yes...done..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19474#discussion_r1623826880
PR Review Comment: https://git.openjdk.org/jdk/pull/19474#discussion_r1623825295
