On Wed, 5 Jun 2024 16:14:11 GMT, Abhishek Kumar <[email protected]> wrote:

>> "java.awt.IllegalComponentStateException: component must be showing on the 
>> screen to determine its location" is thrown when getLocationOnScreen method 
>> is invoked for JTableHeader while testing JFileChooser demo. It seems that 
>> in getLocationOfScreen method we are trying to access the parent location 
>> but that is not visible and ICSE is thrown.
>> 
>> Fix is to handle the exception and can be verified using the steps mentioned 
>> in [JDK-8332550](https://bugs.openjdk.org/browse/JDK-8332550).
>> CI testing is green and link is mentioned in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   copyright year update

src/java.desktop/share/classes/javax/swing/table/JTableHeader.java line 1368:

> 1366:                     try {
> 1367:                         parentLocation = parent.getLocationOnScreen();
> 1368:                     } catch (IllegalComponentStateException icse) {

should we be preventing the exception by checking if the JTableHeader is 
visible or not instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19391#discussion_r1628508394

Reply via email to