On Sat, 8 Jun 2024 00:49:29 GMT, Alisen Chung <[email protected]> wrote:
>> test/jdk/javax/swing/JPopupMenu/MouseDragPopupTest.java line 59:
>>
>>> 57: });
>>> 58: robot.waitForIdle();
>>> 59: robot.delay(1000);
>>
>> Suggestion:
>>
>> robot.setAutoDelay(100);
>> robot.setAutoWaitForIdle(true);
>>
>> SwingUtilities.invokeAndWait(() -> {
>> createAndShowGUI();
>> });
>> robot.delay(1000);
>>
>>
>> I was able to remove all the individual `waitForIdle()` calls and replaced
>> it with `setAutoWaitForIdle()`. Still seemed to work fine on macOS.
>
> Most tests i've looked at aren't using setAutoWaitForIdle(). Are there any
> issues with test stability?
I believe you're right. I recall mouse drag movements having some oddity with
setAutoWaitForIdle. It's probably fine as is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19569#discussion_r1635466752
