On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad <rkannathp...@openjdk.org> wrote:
> Hi Reviewers, > > This fix will resolve page range not printing proper pages if the rage begin > from 2 or above on Mac machines. > I have verified the manual range related tests like PageRanges.java, > ClippedImages.java and test.java and confirmed its fixing the issue. > > Please review and let me know your suggestions if any. src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 225: > 223: if (isRangeSet) { > 224: attributes.add(new PageRanges(from+1, to+1)); > 225: attributes.add(SunPageSelection.RANGE); why was this attribute added, and why is it being removed now? is the bug in SunPageSelection? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19740#discussion_r1645134514