On Wed, 19 Jun 2024 11:15:54 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/bug6492108.java line 113: >> >>> 111: } >>> 112: setDelay(50); >>> 113: return panel; >> >> How does it help? You're delaying EDT. >> >> You should rather call >> [`setDelay(50)`](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) >> to add the delay between method calls. >> >> Alternatively, you can add `-delay 50` to [the test >> arguments](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L460-L467) >> in its `@run` tag. > >> How does it help? You're delaying EDT. > > I was unable to reproduce the failure scenario in my local machine but didn't > observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as > they are able to replicate the failure. > You should rather call > [setDelay(50)](https://github.com/openjdk/jdk/blob/50bed6c67b1edd7736bdf79308d135a4e1047ff0/test/jdk/javax/swing/regtesthelpers/SwingTestHelper.java#L284-L294) > to add the delay between method calls. this change does exactly that, it calls `SwingTestHelper#setDelay` since `bug6492108 extends SwingTestHelper` > I was unable to reproduce the failure scenario in my local machine but didn't > observe any failure in mach5 also. Will ask Vitaly or @azvegint to verify as > they are able to replicate the failure I am able to reproduce the issue locally on Ubuntu 22.04, and the provided fix works fine for me. I assume @vprovodin has already done this testing, since he was the one who provided the solution in the JBS issue description. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1646412776
