On Thu, 20 Jun 2024 20:55:11 GMT, Phil Race <p...@openjdk.org> wrote:
>> Infact `isMnemonicHidden` can also be changed to a `protected` member of the >> class. I will check and update. > > protected members of public classes are part of the API > Go look at javadoc - or generate javadoc for this change and see for > yourself. So this still requires a CSR as written. Yeah..I checked that and the protected members are a part of javadoc. One possible way to not have a CSR is to remove the access modifiers from the method that results in default access specifier. In that case, these methods no longer be a part of javadoc API. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18992#discussion_r1648565337