On Fri, 21 Jun 2024 14:51:39 GMT, Alexey Ivanov <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 153:
>
>> 151: /**
>> 152: * Constructs a {@code BasicSliderUI}.
>> 153: * @deprecated This constructor will be removed in future release
>
> This needs a full stop at the end. It's usually added in `@deprecated` tags.
> Suggestion:
>
> * @deprecated This constructor will be removed in future release.
>
>
> Should we explain *why* it's deprecated?
Second the recommendation for "why". As a "forRemoval=true" deprecation, it
will appear in the "Terminally Deprecated Elements" table on this page:
https://download.java.net/java/early_access/jdk24/docs/api/deprecated-list.html.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649099183