On Thu, 27 Jun 2024 09:04:33 GMT, Ravi Gupta <rgu...@openjdk.org> wrote:

>> This testcase checks for the following assertions for Component events:
>> 
>> 1. When components are resized, moved, hidden and shown the respective 
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component events like 
>> resized/moved are triggered.
>> 3. When a hidden component is hidden again, or a visible component is shown 
>> again, the events should not be fired.
>> 4. When a window is minimized/restored then hidden and shown component 
>> events should be triggered.
>> 
>> Testing:
>> Tested using Mach5(20 times per platform) in macos,linux and windows and got 
>> all pass.
>
> Ravi Gupta has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8333403: Review comments fixed

test/jdk/java/awt/event/ComponentEvent/ComponentEventTest.java line 171:

> 169:         EventQueue.invokeAndWait(() -> {
> 170:             frame.dispose();
> 171:             frame.setVisible(true);

I'm not really understanding this part. Why do you dispose the frame then 
setVisible here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19521#discussion_r1663222437

Reply via email to