On Thu, 4 Jul 2024 10:34:24 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> When a printjob is cancelled midway, `PrinterAbortException `was not thrown > in macos. because > firstly,` cancelCheck` invokes` LWCToolkit.invokeLater` with null as > parameter causing it to fail with NPE and > secondly PrinterAbortException was consumed silently when `printLoop` throws > any exception > which is rectified to throw the PrinterAbortException when encountered.. Looks good to me. I've tested the fix in macos and it works as expected. ------------- Marked as reviewed by tr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20027#pullrequestreview-2166770774
