On Thu, 11 Jul 2024 05:15:19 GMT, Tejesh R <t...@openjdk.org> wrote: >> This test tests the wrapping policy of JTabbedPane in one of the >> subinstructions which is not applicable for macos which does not support >> wrapping or scrolling in tabbed layout. >> It can be seen in "Dictionary" native app amongst others where resizing the >> windows to smaller size does not wrap the tabbedpane. >> Updated test instruction to highlight the macos-not-applicable point.. > > test/jdk/javax/swing/JTabbedPane/bug4666224.java line 52: > >> 50: >> 51: private static final String INSTRUCTIONS = """ >> 52: ON ALL PLATFORMS except macos where pt.6 is not >> applicable > > Instead of mentioning about the exception, I guess you can move it to point > 10 and exclude/include from test instructions (Basically string concat) based > on OS type?
No, that is in logical sequence of testing steps...we probably can do pt1-5+conditional pt 6+pt7-10 but I think this should be fine as it is mentioned upfront... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20068#discussion_r1673413184