On Wed, 24 Jul 2024 07:06:15 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> GTKEngine is not final so it is possible for it to be extended and provided > implementation to finishPainting so it better to safeguard Ok, got it. Will update in next commit. > Also the comment that it is done for Adwaita theme, shouldn't then this code > block be done in native after checking what theme is effective now, as this > may affect Yaru or other theme potentially, no? also to be noted why only in this method, finishPainting returned image is being used, other several places, it does not check the returned image at all.. I am checking the test in my local machine (Ubuntu_22.04 which is having Yaru theme) for which the code is added initially. Will update my findings. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20308#discussion_r1689260316
