On Mon, 29 Jul 2024 06:26:28 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Mismatch in key combinations, I have taken native macos Numbers application >> as reference to verify. Have added `Ctrl-Shift Left/Right` action keys >> similar to `Ctrl-Shift UP/DOWN` which would be expected functionality. I've >> removed those test instructions which are not applicable/implemented/not >> working in Macos keyboard navigation. > > test/jdk/javax/swing/JTable/KeyBoardNavigation.java line 284: > >> 282: Shift-Left/Right Arrow - Extend selection left/right >> one column >> 283: Ctrl-Shift Up/Down Arrow - Extend selection to >> top/bottom of row >> 284: Ctrl-Shift Left/Right Arrow - Extend selection to >> first/last of column > > Although the key combinations worked, I suggest to do some re-phrasing: > > 1. Shift-Up/Down Arrow - Extend selection to one cell up/down for current > selected cell in the column > 2. Shift-Left/Right Arrow - Extend selection to one cell left/right for > current selected cell in the row > 3. Ctrl-Shift Up/Down Arrow - Extend selection to top/bottom row for current > selected cell in the column > 4. Ctrl-Shift Left/Right Arrow - Extend selection to to first/last column for > current selected cell in the row Its not the extension of one cell (Its actually the number of cells in that row/column) and also extend selection for selected cell would not be right phrase, I feel. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20331#discussion_r1694872858
