On Thu, 1 Aug 2024 23:28:19 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> check for null > > test/jdk/javax/swing/JOptionPane/OptionPaneInput.java line 86: > >> 84: f.setSize(300,100); >> 85: PassFailJFrame.addTestWindow(f); >> 86: PassFailJFrame.positionTestWindow(f, >> PassFailJFrame.Position.HORIZONTAL); > > The JOptionPane can be add as a split window using PassFailJFrame.splitUI() > since currently it gets blocked by the testUI. There's no way to use the builder here since JOptionPane.showMessageDialog must be called after the testUI is set visible to reproduce the bug. The JOptionPane dialog is supposed to be covering the testUI because it’s a dialog so I think the test is fine as is ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20359#discussion_r1704431425
