On Fri, 16 Aug 2024 01:01:52 GMT, toshiogata <d...@openjdk.org> wrote:
>> test/langtools/tools/javac/generics/parametricException/ParametricException.java >> line 1: >> >>> 1: /* >> >> since you're renaming this file for jtreg testing anyway could you move the >> jtreg tags down below the imports and expand the wildcard import? > > As you mentioned, it's a good time to make a minor improvement, so I modified > the test. I propose not to edit the renamed files. First of all, the purpose of this PR is to *rename tests* to workaround a _misfeature_ of jtreg. Git does not support renames natively, therefore by editing the renamed files you could break Git ability to detect renaming. Additionally, these tests are not part of client and I am not aware of the practices in Java Compiler team. Expanding wildcard imports should be fine, yet I would rather avoid editing the renamed files as I mentioned above. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20475#discussion_r1719731264
