On Wed, 7 Aug 2024 06:55:30 GMT, Manukumar V S <m...@openjdk.org> wrote:
> java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight > color difference in the background color. This is currently reproduced only > for Oracle Linux. > > The Color object I'm getting for each of these Point objects: > new Point(maxBounds.x + OFFSET, maxBounds.y + OFFSET) --> > java.awt.Color[r=0,g=255,b=0] > new Point(maxBounds.width - OFFSET, maxBounds.y + OFFSET) --> > java.awt.Color[r=0,g=207,b=0] > new Point(maxBounds.width - OFFSET, maxBounds.height - OFFSET) --> > java.awt.Color[r=0,g=255,b=0] > new Point(maxBounds.x + OFFSET, maxBounds.height - OFFSET) --> > java.awt.Color[r=0,g=255,b=0] > > So, the issue occurs for the second Point object --> new > Point(maxBounds.width - OFFSET, maxBounds.y + OFFSET) - > java.awt.Color[r=0,g=207,b=0] > > > Fix: > When the offset is increased from 2 to 5, it works fine in all the platforms. > > This test verifies whether the frame is maximised or not by checking its four > border points(by comparing it's colour with GREEN). But in OEL, the top left > and top right borders are curved, so there is a possibility of error if we > directly compare those points with GREEN colour, that's why an OFFSET is > needed. But an OFFSET of 2 is not sufficient for OEL, and for safety I will > change it to 5. I don't see this issue in Ubuntu as the borders as > rectangular there, but not curved. > > Testing: > Tested using mach5 in all the available platforms and it works fine > everywhere(results attached in bug). > Tested manually in OEL 8 and 9(both x64 and aarch64) and it works fine there > also. This pull request has now been integrated. Changeset: 15b20cb1 Author: Manukumar V S <m...@openjdk.org> Committer: Tejesh R <t...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/15b20cb1fd18b849e49c175737dd3826c8d0ceff Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8337886: java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight color difference Reviewed-by: dnguyen, honkar, serb ------------- PR: https://git.openjdk.org/jdk/pull/20486
