On Wed, 21 Aug 2024 19:12:41 GMT, Manukumar V S <[email protected]> wrote:
>> This PR creates a new test by stabilising and open sourcing a closed test.
>> This test verifies that the OpenGL pipeline does not create artifacts with
>> swing components after window is zoomed to maximum size and then resized
>> back to normal.
>> This test is run twice, with and without the flags "-Dsun.java2d.opengl=True
>> -Dsun.java2d.opengl.fbobject=false" .
>>
>> This is tested(15 times per platform) in all the available mach5 headful
>> platforms and found to be stable.
>
> Manukumar V S has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments fixed: Standardized comments, avoid unnecessary variables
> and string concats
test/jdk/javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java line 133:
> 131: System.out.println("Frame is back to normal");
> 132: frame.setExtendedState(JFrame.NORMAL); //resize from
> 133: // maximum size to normal
I think the comment should be above the frame.setExtendedState(JFrame.NORMAL);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20532#discussion_r1725644440
