On Mon, 19 Aug 2024 07:32:26 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> JFileChooser don't have the mnemonics for open and save button in GTK L&F. >> Fix is to add mnemonics for open and save button. >> Fix can be verified by Swingset2 demo application. Mnemonics in GTK L&F are >> visible once alt key is pressed. >> After running the SwingSet2 application, change the `L&F to GTK` and select` >> JFileChooser demo` from toolbar. Click on `Select Plain JFileChooser` button >> and then press alt key to verify the mnemonics. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Add mnemonics for Save and change Selection mnemonics After some "umming" I think we should withdraw this PR The bug https://bugs.openjdk.org/browse/JDK-4795384 is a VERY old bug which said lots of things didn't have a mnemonic. Looks to me like most were addressed, then a couple which went too far (arguably) were undone in 8080628 and this PR is addressing putting those back under the bug that said there were no mnemonics for more than these. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20612#issuecomment-2306281804
