On Fri, 23 Aug 2024 22:36:51 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Moving files from one directory to another can sometimes be a bit risky, >> especially for `javac` tests, because that implies moving the classes from >> one unnamed package to a different unnamed package. >> >> Please confirm that all tests under `test/langtools/tools/javac` continue to >> pass after the files have been moved. You can either run just those tests, >> or run all langtools `tier1` tests if that is easier. > >> > @jonathan-gibbons Is this a bug in jtreg, or where these files actually >> > improperly named? >> >> Not a bug as such, but maybe a little-known misfeature. `jtreg` has always >> had problems with filenames that could cause confusion, and the general >> sense has generally been, "if it hurts, don't do it!". That being said, our >> overall library API and infrastructure is way better these days than in >> times past, and it might be reasonable to file an Enhancement for `jtreg` to >> have a utility/check/test to detect these anomalous situations. >> >> In the meantime, renaming the files to avoid the problem is the recommended >> solution. > > Filed https://bugs.openjdk.org/browse/CODETOOLS-7903803 @jonathan-gibbons Thank you for your comment and filing jtreg enhancement. I confirmed that all tests under langtools/tools/javac passed after renaming. $ jtreg_7_4_1/jtreg/bin/jtreg -dir:jdk/test/langtools -retain:all -verbose:summary -ignore:quiet -exclude:jdk/test/langtools/ProblemList.txt -jdk:jdk-24+12 tools/javac Directory "JTwork" not found: creating Directory "JTreport" not found: creating Passed: tools/javac/4241573/T4241573.java Passed: tools/javac/4846262/CheckEBCDICLocaleTest.java ... Passed: tools/javac/generics/odersky/Test3.java Passed: tools/javac/generics/odersky/Test4.java Passed: tools/javac/generics/parametricException/J.java Passed: tools/javac/generics/parametricException/ParametricException.java Passed: tools/javac/generics/rare/6665356/T6665356.java Passed: tools/javac/generics/rare/Rare1.java ... Passed: tools/javac/warnings/Serial/RecordExtern.java Passed: tools/javac/warnings/Serial/RecordSerial.java Passed: tools/javac/warnings/Serial/Serial.java Passed: tools/javac/warnings/Serial/SerialMethodArity.java Passed: tools/javac/warnings/Serial/SerialMethodMods.java ... Passed: tools/javac/VersionOpt.java Passed: tools/javac/VoidArray.java Test results: passed: 3,869 ------------- PR Comment: https://git.openjdk.org/jdk/pull/20475#issuecomment-2309542735
