On Fri, 6 Sep 2024 11:18:13 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Open source test
>
> test/jdk/javax/swing/JColorChooser/Test4887836.java line 47:
>
>> 45: // There is no Swatches tab available for GTK L&F, skip the
>> testing.
>> 46: if (UIManager.getLookAndFeel().getName().contains("GTK")) {
>> 47: System.out.println("Test skipped for " +
>> UIManager.getLookAndFeel().getName());
>
> same here
Removed print statement here as well.
> test/jdk/javax/swing/plaf/basic/BasicSliderUI/bug4419255.java line 46:
>
>> 44: // There is no RGB tab available for GTK L&F, skip the testing.
>> 45: if (UIManager.getLookAndFeel().getName().contains("GTK")) {
>> 46: System.out.println("Test skipped for " +
>> UIManager.getLookAndFeel().getName());
>
> guess no need to enquire it again in as we know it's GTK
I think print statement is not required, anyways it is captured in exception,
so removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746972697
PR Review Comment: https://git.openjdk.org/jdk/pull/20867#discussion_r1746972353
