On Tue, 17 Sep 2024 00:23:35 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Clean up and open source five TextField related tests: >> java/awt/TextField/CaretPositionTest; >> java/awt/TextField/SetBoundsTest; >> java/awt/TextField/SetEchoCharTest4; >> java/awt/TextField/SetPasswordTest; >> java/awt/TextField/ZeroEchoCharTest > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Make varible volatile LGTM other than https://github.com/openjdk/jdk/pull/21026/files#r1762115939 test/jdk/java/awt/TextField/CaretPositionTest/CaretPositionTest.java line 51: > 49: private Dimension size; > 50: String text = "12 45 789"; > 51: private volatile static int position = -1; blessed modifier order Suggestion: private static volatile int position = -1; ------------- Marked as reviewed by honkar (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21026#pullrequestreview-2308031741 PR Review Comment: https://git.openjdk.org/jdk/pull/21026#discussion_r1762115939
