On Mon, 16 Sep 2024 09:55:19 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> This changeset refactors `java/awt/event/KeyEvent/FunctionKeyTest.java`. > > Key changes: > > - Use `CyclicBarrier` to verify whether a key is pressed and released; > - Use `CountDownLatch` for frame activation; > - Ensure thread-safety for keeping thrown exceptions. > > Other changes: > > - Made `FunctionKeyTester` a nested class inside `FunctionKeyTest`; > - Used constants for the key events rather than magic numbers. > > I ran the updated test a few times with `JTREG=REPEAT_COUNT=20`, the test has > passed. > > The updated test executes somewhat quicker than the old one. > > @azvegint, you may want to take a look. Marked as reviewed by azvegint (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/21013#pullrequestreview-2308671159
