On Wed, 18 Sep 2024 04:43:50 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add requires tag
Marked as reviewed by aivanov (Reviewer).
test/jdk/java/awt/MenuItem/GiantFontTest.java line 43:
> 41: String INSTRUCTIONS = """
> 42: A frame with one menu will appear.
> 43: On Solaris, the menu's font should be quite large
> (48 point).
What about Linux? Solaris isn't supported by JDK any more.
Here, you may want to clarify where it's referring to a menu (item) on the menu
bar and where the instructions refer to popup menu shown after activating the
item on the menu bar. Just to make the instructions clearer.
test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 51:
> 49: LotsOfMenuItemsTest obj = new LotsOfMenuItemsTest();
> 50: String INSTRUCTIONS = """
> 51: This test creates lots of frames with menubars.
Suggestion:
This test creates lots of frames with menu bars.
It's usually spelt with a space.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21029#pullrequestreview-2312285523
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764818954
PR Review Comment: https://git.openjdk.org/jdk/pull/21029#discussion_r1764810457
