On Wed, 18 Sep 2024 17:51:52 GMT, Phil Race <p...@openjdk.org> wrote:
>> Open source 5 Java2D related rendering tests.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8340078
Changes requested by honkar (Reviewer).
test/jdk/sun/java2d/SunGraphics2D/DrawRoundRect0Bug.java line 31:
> 29:
> 30: import java.awt.Color;
> 31: import static java.awt.Color.*;
Only static import might be required here based on its usage in test.
test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 37:
> 35: public class ScaledPolyTest {
> 36:
> 37: public static void main(String[] arg]) {
Extra bracket
Suggestion:
public static void main(String[] args) {
test/jdk/sun/java2d/SunGraphics2D/ScaledPolyTest.java line 67:
> 65: int bluePix = blue.getRGB();
> 66: int yellowPix = yellow.getRGB();
> 67: int whitePix = white.getRGB();
Sorry for the mix-up with the tests. Somehow the comments got added to the
wrong test.
This test uses both static and non-static usage for Color.
Currently it doesn't compile because the static import was removed.
It might be better to follow one pattern throughout - either non-static or
static?
-------------
PR Review: https://git.openjdk.org/jdk/pull/21045#pullrequestreview-2313420538
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765499341
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765509992
PR Review Comment: https://git.openjdk.org/jdk/pull/21045#discussion_r1765508604
