On Wed, 18 Sep 2024 23:52:34 GMT, Harshitha Onkar <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor review > > test/jdk/java/awt/Robot/RobotScrollTest.java line 47: > >> 45: private static final String INSTRUCTIONS = """ >> 46: 0. DON'T TOUCH ANYTHING! >> 47: 1. This test is for Win32 and Linux only. > > Suggestion: > > 1. This test is for Win and Linux only. done > test/jdk/java/awt/Robot/RobotScrollTest.java line 82: > >> 80: Point taAt = ta.getLocationOnScreen(); >> 81: // get bounds of button >> 82: Rectangle bounds = ta.getBounds(); > > Should they be in EDT? manual test, not needed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766112199 PR Review Comment: https://git.openjdk.org/jdk/pull/21062#discussion_r1766112387
