On Fri, 20 Sep 2024 05:30:45 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Formatting, EDT addition
>
> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 53:
>
>> 51: static Dialog dialog = null;
>> 52: static volatile boolean passed;
>> 53: static Point loc;
>
> Should it be volatile also?
ok
> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 107:
>
>> 105: private static void doRequestFocusToTextField() {
>> 106: // do activation using press title
>> 107: r.mouseMove(loc.x + frame.getWidth() / 2, loc.y +
>> frame.getInsets().top / 2);
>
> `frame.getWidth` also should be on EDT ?
ok
> test/jdk/java/awt/Focus/ComponentLostFocusTest.java line 121:
>
>> 119: r.setAutoDelay(100);
>> 120:
>> 121: ComponentLostFocusTest test;
>
> Unused variable.
removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768008256
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768007088
PR Review Comment: https://git.openjdk.org/jdk/pull/21051#discussion_r1768007142
