On Fri, 20 Sep 2024 06:36:24 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/java/awt/Frame/DefaultLocationTest.java line 59:
>
>> 57: EventQueue.invokeAndWait(() -> {
>> 58: if (f != null) {
>> 59: f.dispose();
>
> We add "f" to PassFailJFrame through `addTestWIndow` so I would assume
> `awaitAndCheck` should dispose off the frame when we press Pass/Fail, no need
> to do it explicitly..
Ok.. updated.
> test/jdk/java/awt/Frame/FrameLayoutTest.java line 33:
>
>> 31: * @library /java/awt/regtesthelpers
>> 32: * @requires (os.family == "windows")
>> 33: * @build PassFailJFrame
>
> guess @library @build placement should be together, although not mandatory I
> presume..
Keeping it as it is.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768167394
PR Review Comment: https://git.openjdk.org/jdk/pull/21052#discussion_r1768167699
