On Fri, 23 Aug 2024 05:24:16 GMT, Abhishek Kumar <[email protected]> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix import
>
> src/java.desktop/share/classes/java/awt/TextArea.java line 610:
>
>> 608:
>> 609: @Override
>> 610: public synchronized void setEditable(boolean b) {
>
> `setEditable` method is overridden in both `TextArea` and `TextField` class
> and method implementation is same. Since both of them are inherited from
> `TextComponent` class, could we move the code to `TextComponent's
> setEditable` method and remove them from respective classes?
This is a good suggestion.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19876#discussion_r1771426903
