On Tue, 24 Sep 2024 02:27:07 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments updated
>
> test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 98:
>
>> 96:
>> 97: public void mousePressed(MouseEvent e) {
>> 98: }
>
> I guess if you use MouseAdapter instead of MouseListener, then you only have
> to provide implementation for the method you need, not for all..
Yes, good one. Have updated.
> test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 128:
>
>> 126: if (e.getID() == MouseEvent.MOUSE_EXITED)
>> 127: type = "MOUSE_EXITED";
>> 128:
>
> MOUSE_ENTERED is used twice...Also, it seems you are only printing
> MouseExit/Enter so other types can be deleted..
Updated.
> test/jdk/java/awt/Mouse/MouseDragEnterExitTest.java line 168:
>
>> 166: public void mouseClicked(MouseEvent e) {
>> 167: }
>> 168:
>
> same here...MouseAdapter...
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772571883
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772571943
PR Review Comment: https://git.openjdk.org/jdk/pull/21126#discussion_r1772572019
