On Thu, 19 Sep 2024 11:54:56 GMT, Nikita Gubarkov <ngubar...@openjdk.org> wrote:

>> I moved SurfaceDataProxy cache into a separate class.
>> Now caching level is determined by placement of the 
>> SurfaceManager.ProxyCache object instead of a "proxy key". This cache "owns" 
>> proxies and therefore strong refs via them do not prevent the cache and 
>> GraphicsConfig from being detected as weakly reachable.
>
> Nikita Gubarkov has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Revert wildcard import in X11GraphicsDevice

I ran the latest version of the PR through our automated test system and all 
looks good, although obviously that isn't detaching and reattaching monitors 
... so I need to spend some time understanding the fix.
Also this absolutely needs at least two reviewers. @jayathirthrao and @azvegint 
 please review as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20825#issuecomment-2374694339

Reply via email to