On Wed, 25 Sep 2024 10:54:09 GMT, Alexey Ivanov <[email protected]> wrote:
>> I re-worked the entire description of `PassFailJFrame`:
>>
>> Add description of what UI elements it provides and how to interact with
>> them.
>> Add anchors for linking to the sections.
>>
>> Use `{@snippet}` instead of `<pre>{@code}</pre>` for sample code.
>> Use method references instead of lambdas in samples.
>> Document required jtreg tags to use `PassFailJFrame`.
>> Rename `SampleOldManualTest` to `ObsoleteManualTest`.
>>
>> Provide an overview of `Builder` methods to configure `PassFailJFrame`.
>>
>> As in #21145, the generated javadoc
>> [PassFailJFrame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html)
>> could be easier to read and review.
>>
>> The current version of the generated docs contains changes from #21145 and
>> this PR. The PRs can be integrated independently.
>
> Alexey Ivanov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Amend: and handles timeout.
Marked as reviewed by prr (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21162#pullrequestreview-2329521434
