On Wed, 25 Sep 2024 11:46:00 GMT, Matthias Baesken <[email protected]> wrote:
> It has been discussed that checking the return value of pthread_create should > be done. > See the discussion here https://github.com/openjdk/jdk/pull/20812 about the > splashscreen coding . Looks good overall, just one nit. I guess it's ok to print a warning to stderr in this case. src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m line 278: > 276: int rslt = pthread_attr_init(&attr); > 277: if (rslt != 0) return; > 278: rc = pthread_create(&thr, &attr, SplashScreenThread, (void *) > splash); For the sake of symmetry, could you rename rc to rslt here? ------------- Changes requested by clanger (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21182#pullrequestreview-2330276303 PR Review Comment: https://git.openjdk.org/jdk/pull/21182#discussion_r1776482707
