On Mon, 23 Sep 2024 13:17:09 GMT, Severin Gehwolf <[email protected]> wrote:

>> ping @prrace
>
> @Karm There are a few things that have not yet been addressed:
> 
> - @avu mentioned 
> [here](https://github.com/openjdk/jdk/pull/20169#discussion_r1677699984) that 
> copyright years of the file need updating
> - There is a title mismatch between this PR and the JBS entry. Which one 
> should it be if any? (and I'll help you fix that one).
> 
> I'd also merge in latest master since x86 tests have since been disabled. 
> That should fix the GHA issue.
> 
> Thanks!

Hello @jerboaa,

> * @avu mentioned 
> [here](https://github.com/openjdk/jdk/pull/20169#discussion_r1677699984) that 
> copyright years of the file need updating

The year there is 2024 for both edited files.

> * There is a title mismatch between this PR and the JBS entry. Which one 
> should it be if any? (and I'll help you fix that one).

Use the title from this PR, please.

> I'd also merge in latest master since x86 tests have since been disabled. 
> That should fix the GHA issue.

Done.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20169#issuecomment-2381018969

Reply via email to