On Mon, 30 Sep 2024 03:32:23 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved variables initialization into the method that is called on EDT;
>> Moved dispose call onto EDT so it is called even if test is failed;
>> Added missing window dispose call;
>
> test/jdk/java/awt/Component/BackgroundColorTest/InitialBackgroundSettingTest.java
> line 52:
>
>> 50: Scrollbar bar = new Scrollbar(Scrollbar.HORIZONTAL);
>> 51: Button button = new Button("I am the button");
>> 52:
>
> I believe all this initialization needs to be put in `setupGUI` under
> EDT..more so as it is an automated test..
Fixed.
> test/jdk/java/awt/Component/ListDoubleIndentTest/ListDoubleIndentTest.java
> line 66:
>
>> 64:
>> 65: try {
>> 66: Frame f = new Frame("ListDoubleIndentTest");
>
> dispose is missing
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21235#discussion_r1781852988
PR Review Comment: https://git.openjdk.org/jdk/pull/21235#discussion_r1781853061
